Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: title が1文の場合の対処 #5

Merged
merged 4 commits into from
Dec 8, 2024
Merged

fix: title が1文の場合の対処 #5

merged 4 commits into from
Dec 8, 2024

Conversation

SatooRu65536
Copy link
Member

close #3

修正内容

title が1文(array ではなく string扱い)であってもエラーにならないようにした

#show: template.with(
  title: ("1st line only"),
  ...
)

そもそも↓と, を入れればいんだけどね

#show: template.with(
  title: ("1st line only",),
  ...
)

@SatooRu65536 SatooRu65536 added the bug Something isn't working label Nov 30, 2024
@SatooRu65536 SatooRu65536 self-assigned this Nov 30, 2024
kanakanho
kanakanho reviewed Nov 30, 2024
View reviewed changes
template/head.typ Outdated Show resolved Hide resolved
kanakanho
kanakanho reviewed Nov 30, 2024
View reviewed changes
Copy link
Member

@kanakanho kanakanho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main.pdfを更新してもいいと思う

kanakanho
kanakanho approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@kanakanho kanakanho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード自体はLGTMです！

@SatooRu65536 SatooRu65536 merged commit 27b196a into main Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanakanho kanakanho kanakanho approved these changes

Assignees

@SatooRu65536 SatooRu65536

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: titleが1行に収まっている場合、コンパイルエラーが発生する
2 participants
@SatooRu65536 @kanakanho